Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Reflecting ARIA attributes' from experimental FX relnotes; add ARIA reflection to FX119 relnotes #29521

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

zfox23
Copy link
Contributor

@zfox23 zfox23 commented Oct 6, 2023

Description

  • Removes 'Reflecting ARIA attributes' from experimental Firefox release notes
  • Adds ARIA Reflection to FX119 release notes under APIs -> DOM

Motivation

The browser is changing, and we must keep up!

Additional details

https://bugzilla.mozilla.org/show_bug.cgi?id=1785412

Related issues and pull requests

Child of #29311
Should be merged along with mdn/browser-compat-data#20911

@zfox23 zfox23 requested a review from a team as a code owner October 6, 2023 17:06
@zfox23 zfox23 requested review from Elchi3 and removed request for a team October 6, 2023 17:06
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Preview URLs

External URLs (81)

URL: /en-US/docs/Mozilla/Firefox/Releases/119
Title: Firefox 119 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2023-10-06 20:04:23)

@dipikabh dipikabh self-assigned this Oct 6, 2023
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zfox23. This looks good overall.
I've suggested a few edits and have a question about the example.

@@ -42,6 +42,8 @@ This article provides information about the changes in Firefox 119 that affect d

#### DOM

- [ARIA](/en-US/docs/Web/Accessibility/ARIA) reflection is enabled for attributes that do not reference other elements; only non-IDREF attributes are reflected. This allows developers to get and set ARIA attributes on DOM elements directly via JavaScript APIs, rather than by using `setAttribute` and `getAttribute`. For example, `el.ariaPressed = "true";` is now supported in addition to `el.setAttribute("aria-pressed", "true");`. (See [Firefox bug 1785412](https://bugzil.la/1785412) for more details.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should we say "now supported by default" because it could be enabled earlier but after setting the preference?
  • Looking at a previous release note to keep the styling consistent for referencing the Fx bug.
  • The addition of a quick example is really good here! 👍. I am wondering if el should be <element>. Or perhaps, we should provide an actual example like button.ariaPressed = "true";?
Suggested change
- [ARIA](/en-US/docs/Web/Accessibility/ARIA) reflection is enabled for attributes that do not reference other elements; only non-IDREF attributes are reflected. This allows developers to get and set ARIA attributes on DOM elements directly via JavaScript APIs, rather than by using `setAttribute` and `getAttribute`. For example, `el.ariaPressed = "true";` is now supported in addition to `el.setAttribute("aria-pressed", "true");`. (See [Firefox bug 1785412](https://bugzil.la/1785412) for more details.)
- [ARIA](/en-US/docs/Web/Accessibility/ARIA) reflection is now supported by default for attributes that do not reference other elements; only non-IDREF attributes are reflected. You can now get and set ARIA attributes on DOM elements directly via JavaScript APIs, rather than by using `setAttribute` and `getAttribute`. For example, `el.ariaPressed = "true";` is now supported in addition to `el.setAttribute("aria-pressed", "true");` ([Firefox bug 1785412](https://bugzil.la/1785412)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should we say "now supported by default" because it could be enabled earlier but after setting the preference?

Yeah, I like that!

Thanks :)

  • The addition of a quick example is really good here! 👍. I am wondering if el should be <element>. Or perhaps, we should provide an actual example like button.ariaPressed = "true";?

Ooh, okay, I have changed it to buttonElement.ariaPressed = "true";, which I think is better and more clear. WDYT?

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good, thank you! 👍

@dipikabh dipikabh merged commit dacaf52 into mdn:main Oct 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants