-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'Reflecting ARIA attributes' from experimental FX relnotes; add ARIA reflection to FX119 relnotes #29521
Conversation
…d ARIA reflection to FX119 relnotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zfox23. This looks good overall.
I've suggested a few edits and have a question about the example.
@@ -42,6 +42,8 @@ This article provides information about the changes in Firefox 119 that affect d | |||
|
|||
#### DOM | |||
|
|||
- [ARIA](/en-US/docs/Web/Accessibility/ARIA) reflection is enabled for attributes that do not reference other elements; only non-IDREF attributes are reflected. This allows developers to get and set ARIA attributes on DOM elements directly via JavaScript APIs, rather than by using `setAttribute` and `getAttribute`. For example, `el.ariaPressed = "true";` is now supported in addition to `el.setAttribute("aria-pressed", "true");`. (See [Firefox bug 1785412](https://bugzil.la/1785412) for more details.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we say "now supported by default" because it could be enabled earlier but after setting the preference?
- Looking at a previous release note to keep the styling consistent for referencing the Fx bug.
- The addition of a quick example is really good here! 👍. I am wondering if
el
should be<element>
. Or perhaps, we should provide an actual example likebutton.ariaPressed = "true";
?
- [ARIA](/en-US/docs/Web/Accessibility/ARIA) reflection is enabled for attributes that do not reference other elements; only non-IDREF attributes are reflected. This allows developers to get and set ARIA attributes on DOM elements directly via JavaScript APIs, rather than by using `setAttribute` and `getAttribute`. For example, `el.ariaPressed = "true";` is now supported in addition to `el.setAttribute("aria-pressed", "true");`. (See [Firefox bug 1785412](https://bugzil.la/1785412) for more details.) | |
- [ARIA](/en-US/docs/Web/Accessibility/ARIA) reflection is now supported by default for attributes that do not reference other elements; only non-IDREF attributes are reflected. You can now get and set ARIA attributes on DOM elements directly via JavaScript APIs, rather than by using `setAttribute` and `getAttribute`. For example, `el.ariaPressed = "true";` is now supported in addition to `el.setAttribute("aria-pressed", "true");` ([Firefox bug 1785412](https://bugzil.la/1785412)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we say "now supported by default" because it could be enabled earlier but after setting the preference?
Yeah, I like that!
- Looking at a previous release note to keep the styling consistent for referencing the Fx bug.
Thanks :)
- The addition of a quick example is really good here! 👍. I am wondering if
el
should be<element>
. Or perhaps, we should provide an actual example likebutton.ariaPressed = "true";
?
Ooh, okay, I have changed it to buttonElement.ariaPressed = "true";
, which I think is better and more clear. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look good, thank you! 👍
Description
Motivation
The browser is changing, and we must keep up!
Additional details
https://bugzilla.mozilla.org/show_bug.cgi?id=1785412
Related issues and pull requests
Child of #29311
Should be merged along with mdn/browser-compat-data#20911